Skip to content

remove duplicate flowcontroller listener#11642

Merged
EarthChen merged 2 commits intoapache:3.2from
icodening:duplicate_controller
Feb 25, 2023
Merged

remove duplicate flowcontroller listener#11642
EarthChen merged 2 commits intoapache:3.2from
icodening:duplicate_controller

Conversation

@icodening
Copy link
Contributor

@icodening icodening commented Feb 24, 2023 •
edited
Loading

What is the purpose of the change

remove duplicate flowcontroller listener

Brief changelog

add TripleHttp2FrameCodecBuilder to customize connection before building

Verifying this change

before:
image

after:
image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #11642 (1a9b61f) into 3.2 (638b193) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11642      +/-   ##
============================================
- Coverage     69.50%   69.40%   -0.11%     
+ Complexity      341        2     -339     
============================================
  Files          3096     1453    -1643     
  Lines        147362    61364   -85998     
  Branches      24563     9056   -15507     
============================================
- Hits         102427    42590   -59837     
+ Misses        35763    14594   -21169     
+ Partials       9172     4180    -4992
Impacted Files Coverage Δ
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 54.54% <0.00%> (-18.19%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 72.41% <0.00%> (-6.90%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 64.00% <0.00%> (-4.00%) ⬇️
.../dubbo/monitor/support/AbstractMonitorFactory.java 80.00% <0.00%> (-3.34%) ⬇️
...moting/transport/netty4/NettyConnectionClient.java 74.83% <0.00%> (-3.23%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 78.12% <0.00%> (-3.13%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 69.55% <0.00%> (-1.39%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-1.14%) ⬇️
...bo/rpc/protocol/tri/stream/TripleClientStream.java 66.22% <0.00%> (-0.89%) ⬇️
...e/dubbo/registry/integration/DynamicDirectory.java 71.68% <0.00%> (-0.89%) ⬇️
... and 1667 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlbumenJ
AlbumenJ approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EarthChen PTAL

EarthChen
EarthChen approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 837b9c5 into apache:3.2 Feb 25, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 27, 2023
@mytang0
Merge remote-tracking branch 'origin/3.2' into refactor-sliding-window
e217122 
* origin/3.2:
  sync reflect config (apache#11668)
  Fix qos command remote check (apache#11506)
  Fix license check
  Add 'label match' support for override and tag rules (apache#11094)
  Dubbo maven plugin with native (apache#11540)
  fix: fix observation spi config (apache#11660)
  Update .licenserc.yaml
  fix tri wrapper pack npe (apache#11656)
  remove duplicate flowcontroller listener (apache#11642)
  Metrics RT count optimization (apache#11628)
  Observability task: registration center (apache#11493)
  Migration bugfix & optimization (apache#11629)
  Fix service name mapping check failed (apache#11643)
  fix: executor (apache#11652)
  Fix license check
  fixed broken link readme.md (apache#11641)
@icodening icodening deleted the duplicate_controller branch February 27, 2023 06:45
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
@icodening @lcb11
remove duplicate flowcontroller listener (apache#11642)
05cbbc2 
* remove duplicate flowcontroller listener

* remove duplicate flowcontroller listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

@EarthChen EarthChen EarthChen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@icodening @codecov-commenter @AlbumenJ @EarthChen